【Tetris Game -- based on a shell script】(new algorithm) - Page 2

smr54 · #16 25th December 2011, 01:29 PM

Thanks for adding the attachment--honestly, I think it's a good idea. It works for me, so I'm guessing something went wrong with trying to copy it from the web link.

(I should add, it works with bash Tetris_Game.sh, but does NOT work with sh Tetris_Game.sh. Nothing wrong with that of course, it's a bash script, not a /bin/sh script).

Thanks for your efforts, and thank you for creating it as an attachment.

huaihaizi3 · #17 26th December 2011, 01:21 PM

I added some New code!

huaihaizi3 · #18 2nd January 2012, 12:10 PM

Tetris Game Version 4.0 ---Final Version released!

huaihaizi3 · #19 7th January 2012, 05:00 PM

new updates!

stevea · #20 7th January 2012, 06:14 PM

Quote:

Originally Posted by huaihaizi3

Hi all, i have successfully developed a shell version of the Tetris Game based on a new algorithm few days ago all by myself, below is the link of the source code that i posted at a Linux/Unix forum the first in China:
http://bbs.chinaunix.net/thread-3614425-1-1.html
I'd love to know that someone can be able to optimize my source code and enhance it!

Nice game.

The bash coding style is good. Good clear names and a good attempt to decompose the task into utility functions. I might have made a different decomposition - but that's a matter of the specifics of the goal.

Criticism: Are sed & awk needed ? Have you looked for a bash feature instead ? For example this sort of thing is very awkward ..
echo -e "$(sed 's/\[\]/ /g' <(echo ${oldbox}))\e[0m";
might be replaced with the bash pattern substitution ${parameter/pattern/string}.

The screen codes are non-portable. Things like this ....
echo -e "\e[?25h\e[36;4H"
only apply to VT100 terminals and xterms that emulate these. Better to use the 'tput' function to access curses. tput can give you the portable strings to position the cursor, set color foreground and background ,set bold, normal etc. like tput cup 35 3 .

--------

Quote:

When the thought has been dominated by a scientific sense, is influenced by a rational concept, the fate of the result will change the trajectory of life will also be moving in the direction of extension of the successful

I imagine that made a lot more sense before translation

huaihaizi3 · #21 8th January 2012, 04:15 AM

Quote:

Originally Posted by stevea

Criticism: Are sed & awk needed ? Have you looked for a bash feature instead ? For example this sort of thing is very awkward ..
echo -e "$(sed 's/\[\]/ /g' <(echo ${oldbox}))\e[0m";
might be replaced with the bash pattern substitution ${parameter/pattern/string}.

The screen codes are non-portable. Things like this ....
echo -e "\e[?25h\e[36;4H"
only apply to VT100 terminals and xterms that emulate these. Better to use the 'tput' function to access curses. tput can give you the portable strings to position the cursor, set color foreground and background ,set bold, normal etc. like tput cup 35 3 .

Thank you!
Good advices!
There is a better solution that can replace the maxxy function

Code:

maxyx()
{
   local i a b
   set -- ${box[@]} 
   a[$2]=${1} 
   b[$2]="${1} ${2}" && shift 2
   while (( ${#} > 0 ))
   do
         (( a[$2] < ${1} )) && a[$2]=${1}
         b[$2]="${a[$2]} ${2}"
         shift 2
   done
   echo ${b[@]}
}

I also replaced the sed with the bash pattern substitution, just as you said ,it's better to use the shell builtin features!
For the issue of portable, i'm sorry ,i have no much time to deal with it!